chore: integrate latest ldk-node and bitkit-core#718
Conversation
This comment has been minimized.
This comment has been minimized.
ovitrif
changed the base branch from
master
to
claude/issue-548-20260120-1551
ovitrif
changed the title
ovitrif
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
ovitrif
force-pushed
the
feat/optimise-ldk-node-use
branch
2 times, most recently
from
50b5703 to
dded9a5
Compare
Pull request was converted to draft
This comment was marked as resolved.
This comment was marked as resolved.
ovitrif
force-pushed
the
feat/optimise-ldk-node-use
branch
from
dded9a5 to
1d9bbe6
Compare
ovitrif
force-pushed
the
feat/optimise-ldk-node-use
branch
from
76beac4 to
aeadbe9
Compare
This comment has been minimized.
This comment has been minimized.
|
LGTM, doing sanity tests... |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
still need to fix LNURL-channel after bitkit-core changes. see: plan |
|
probably fixes |
|
@piotr-iohk the LNURL-channel e2e failures were due to changes in a recent bitkit-core version and misalignment on the android side, which should now be fixed in commit: Let's see if the e2e succeed 🤞🏻 |
Screen_recording_20260126_121653.webmThe app status screen show an Electrum error connection but the detail screen show success. I'll check if also happens on master |
It's a known issue, I don't think you'll be able to repro it that easily. |
|
@jvsena42 do you have the logs from this? |
bitkit_2026-01-26_15-16-16.log It is intermittent and didn't find a relation with this branch |
jvsena42
left a comment
jvsena42
left a comment
There was a problem hiding this comment.
- Migration
- Performed Lightning operations
Can't repro it on this branch but I saw it quite often (last week-ish). Especially when clicking the wake2 notification |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
4 participants
Fixes: #723
Fixes: #667
Description
QA Notes
Use CI checks.